Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

From: Christoph Hellwig
Date: Wed Mar 21 2018 - 14:50:16 EST


On Wed, Mar 21, 2018 at 12:38:54PM -0300, Arnaldo Carvalho de Melo wrote:
> assert_spin_locked(&cmd->t_state_lock);
> - WARN_ON_ONCE(!irqs_disabled());
> + WARN_ON_ONCE_NONRT(!irqs_disabled());

I can't find where WARN_ON_ONCE_NONRT is defined.

That being said I think we can just kill these asserts. If we have irqs
disabled spin_unlock_irq a few lines below should already warn.