Re: [PATCHv2 2/2] bpftool: Adjust to new print_bpf_insn interface

From: Quentin Monnet
Date: Wed Mar 21 2018 - 13:30:38 EST


2018-03-21 18:00 UTC+0100 ~ Jiri Olsa <jolsa@xxxxxxxxxx>
> On Wed, Mar 21, 2018 at 05:44:52PM +0100, Daniel Borkmann wrote:
>
> SNIP
>
>>>> Hi Jiri, this code has changed in the tree. It was moved to
>>>> tools/bpf/bpftool/xlated_dumper.c, and there is now a third function to
>>>> update: print_insn_for_graph(). Could you please rebase the patch?
>>>
>>> sure.. I was over perf tree, I'll check on bpf tree
>>
>> Just to be sure, it should be bpf-next. bpf is for fixes only.
>
> v2 attached
>
> thanks,
> jirka
>
>
> ---
> Change bpftool to skip the removed struct bpf_verifier_env
> argument in print_bpf_insn. It was passed as NULL anyway.
>
> No functional change intended.
>
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> ---
> tools/bpf/bpftool/xlated_dumper.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>

Thank you!
Reviewed-by: Quentin Monnet <quentin.monnet@xxxxxxxxxxxxx>