Re: [PATCH ghak21 V4 2/2] audit: add refused symlink to audit_names

From: Paul Moore
Date: Wed Mar 21 2018 - 11:49:36 EST


On Wed, Mar 21, 2018 at 4:42 AM, Richard Guy Briggs <rgb@xxxxxxxxxx> wrote:
> Audit link denied events for symlinks had duplicate PATH records rather
> than just updating the existing PATH record. Update the symlink's PATH
> record with the current dentry and inode information.
>
> See: https://github.com/linux-audit/audit-kernel/issues/21
> Signed-off-by: Richard Guy Briggs <rgb@xxxxxxxxxx>
> ---
> fs/namei.c | 1 +
> 1 file changed, 1 insertion(+)

Merged. Thanks for the audit log examples.

> diff --git a/fs/namei.c b/fs/namei.c
> index e3682bb..5f8e8e2 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -945,6 +945,7 @@ static inline int may_follow_link(struct nameidata *nd)
> if (nd->flags & LOOKUP_RCU)
> return -ECHILD;
>
> + audit_inode(nd->name, nd->stack[0].link.dentry, 0);
> audit_log_link_denied("follow_link");
> return -EACCES;
> }
> --
> 1.8.3.1

--
paul moore
www.paul-moore.com