Re: [PATCH v8 01/12] drivers: base: Unified device connection lookup

From: Heikki Krogerus
Date: Tue Mar 20 2018 - 08:52:51 EST


On Tue, Mar 20, 2018 at 01:21:57PM +0100, Hans de Goede wrote:
> On 20-03-18 11:32, Heikki Krogerus wrote:
> > On Tue, Mar 20, 2018 at 12:04:12PM +0200, Heikki Krogerus wrote:
> > > > > +void device_connection_remove(struct device_connection *con)
> > > > > +{
> > > > > + mutex_lock(&devcon_lock);
> > > > > + list_del_rcu(&con->list);
> > > >
> > > > See, rcu?
> > >
> > > True. I'll send one more version.
> >
> > Before I do that, Hans, can you quickly check this and see that I
> > have not made any more mistakes? I don't trust myself anymore with
> > these.
>
> This looks good to me (note I did not test only reviewed).

Thanks. I'll send v9.

Br,

--
heikki