Re: [PATCH] Staging: xgifb: XGI_main_26.c: Refactored the function

From: Dan Carpenter
Date: Tue Mar 20 2018 - 07:21:23 EST


I'm trying to review this, but I feel like this makes it slightly more
complicated for no reason. Why break it up into two loops?

> - i++;
> + ++i;

These are equivalent, so you should default to accepting the original
author's style. Otherwise the next person to touch this code will just
change it back and we get into a cycle of pointless changes.

regards,
dan carpenter