Re: [PATCH 4.14 056/109] clk: ti: clkctrl: add support for retrying failed init

From: Sasha Levin
Date: Mon Mar 19 2018 - 12:42:26 EST


On Mon, Mar 19, 2018 at 08:57:30AM +0200, Tero Kristo wrote:
>On 19/03/18 05:44, Dan Rue wrote:
>>On Fri, Mar 16, 2018 at 04:23:25PM +0100, Greg Kroah-Hartman wrote:
>>>4.14-stable review patch. If anyone has any objections, please let me know.
>>>
>>>------------------
>>>
>>>From: Tero Kristo <t-kristo@xxxxxx>
>>>
>>>
>>>[ Upstream commit 729e13bf58e643b9accd2a14c55b555958702fb0 ]
>>>
>>>In case the clkctrl node contains assigned-clock-* entries, registering
>>>the provider can fail with -EPROBE_DEFER. In this case, add the
>>>provider to the retry_init clock list so it will be cleaned up later.
>>>
>>>Signed-off-by: Tero Kristo <t-kristo@xxxxxx>
>>>Acked-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
>>>Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxxxx>
>>>Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>>
>>This fails to build for me on arm32:
>>
>>$ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-arm multi_v7_defconfig
>>$ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-arm
>
>This actually needs commit ffb009b24388b896d9ca8b54e39a879302142518
>("clk: ti: convert retry_init param to use void data type") as
>prerequisite, otherwise it fails building.

I'll pick both up for the next cycle, thanks!

--

Thanks,
Sasha