Re: [PATCH v1 02/19] dt-bindings: cpufreq: mediatek: use - instead of _ in examples

From: Matthias Brugger
Date: Mon Mar 19 2018 - 06:35:15 EST


Hi Sean,

On 03/19/2018 03:51 AM, Sean Wang wrote:
>
> Hi, Matthias
>
> I'm worried you missed the patch which already got both tags Reviewed-by
> from Rob and Acked-by: Viresh and thus I thought it
> should be ready for your tree.
>

Yes, sorry I missed this one. Fortunately it is not critical, can you please add
it to v2.

I suppose you realized that I didn't take any from 12/19 onwards, especially 14,
15 and 17, because they have many conflicts with previous patches in the series.

Sorry for the inconvenience.
Matthias

> For the other patches in the same series, I will have v2 to refine them
> according to these suggestions and comments in v1 and let them easy to
> review.
>
> Really thanks for your effort!
>
> Sean
>
>
> On Mon, 2018-02-26 at 09:43 +0530, Viresh Kumar wrote:
>> On 23-02-18, 18:16, sean.wang@xxxxxxxxxxxx wrote:
>>> From: Sean Wang <sean.wang@xxxxxxxxxxxx>
>>>
>>> It should be good that no use "_" is in examples. Consequently,
>>> those nodes in certain files which have an inappropriate name containing
>>> "_" are all being replaced with "-".
>>>
>>> Signed-off-by: Sean Wang <sean.wang@xxxxxxxxxxxx>
>>> Cc: "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>
>>> Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>>> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
>>> Cc: Mark Rutland <mark.rutland@xxxxxxx>
>>> Cc: linux-pm@xxxxxxxxxxxxxxx
>>> Cc: devicetree@xxxxxxxxxxxxxxx
>>> ---
>>> Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt
>>> index d36f07e..38cfbb5 100644
>>> --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt
>>> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt
>>> @@ -26,7 +26,7 @@ Optional properties:
>>>
>>> Example 1 (MT7623 SoC):
>>>
>>> - cpu_opp_table: opp_table {
>>> + cpu_opp_table: opp-table {
>>> compatible = "operating-points-v2";
>>> opp-shared;
>>>
>>> @@ -86,7 +86,7 @@ Example 1 (MT7623 SoC):
>>> };
>>>
>>> Example 2 (MT8173 SoC):
>>> - cpu_opp_table_a: opp_table_a {
>>> + cpu_opp_table_a: opp-table-a {
>>> compatible = "operating-points-v2";
>>> opp-shared;
>>>
>>> @@ -131,7 +131,7 @@ Example 2 (MT8173 SoC):
>>> };
>>> };
>>>
>>> - cpu_opp_table_b: opp_table_b {
>>> + cpu_opp_table_b: opp-table-b {
>>> compatible = "operating-points-v2";
>>> opp-shared;
>>
>> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>>
>
>