Re: [PATCH 1/2] pci: host: pci-hyperv: Replace GFP_ATOMIC with GFP_KERNEL in hv_pci_onchannelcallback

From: Jia-Ju Bai
Date: Sun Mar 18 2018 - 23:44:29 EST




On 2018/3/19 10:52, KY Srinivasan wrote:

-----Original Message-----
From: Jia-Ju Bai <baijiaju1990@xxxxxxxxx>
Sent: Sunday, March 18, 2018 7:53 AM
To: KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang Zhang
<haiyangz@xxxxxxxxxxxxx>; Stephen Hemminger
<sthemmin@xxxxxxxxxxxxx>; bhelgaas@xxxxxxxxxx
Cc: devel@xxxxxxxxxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; linux-
kernel@xxxxxxxxxxxxxxx; Jia-Ju Bai <baijiaju1990@xxxxxxxxx>
Subject: [PATCH 1/2] pci: host: pci-hyperv: Replace GFP_ATOMIC with
GFP_KERNEL in hv_pci_onchannelcallback

hv_pci_onchannelcallback() is not called in atomic context.

The call chain ending up at hv_pci_onchannelcallback() is:
[1] hv_pci_onchannelcallback() <- hv_pci_probe()
hv_pci_probe() is only set as ".probe" in hv_driver
structure "hv_pci_drv".
This function is setup as the function to handle interrupts on the channel. Hence the
need for GFP_ATOMIC.


Oh, sorry for my incorrect patch.
Thanks for your reply :)


Best wishes,
Jia-Ju Bai