Re: [PATCH net-next] net: dsa: mv88e6xxx: Fix missing register lock in serdes_get_stats

From: David Miller
Date: Sun Mar 18 2018 - 16:36:44 EST


From: Florian Fainelli <f.fainelli@xxxxxxxxx>
Date: Sun, 18 Mar 2018 11:23:05 -0700

> We can hit the register lock not held assertion with the following path:
...
> mv88e6xxx_get_ethtool_stats() calls mv88e6xxx_get_stats() which calls both
> chip->info->ops->stats_get_stats(), which holds the register lock, and
> chip->info->ops->serdes_get_stats() which does not. Have
> chip->info->ops->serdes_get_stats() be running with the register lock held to
> avoid such assertions.
>
> Fixes: 436fe17d273b ("net: dsa: mv88e6xxx: Allow the SERDES interfaces to have statistics")
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Applied, thanks Florian.