Re: [PATCH 1/2] brcmfmac: add new dt entries for SG SDIO settings

From: Andrew Lunn
Date: Sun Mar 18 2018 - 16:01:45 EST


> + if (of_property_read_u16(np, "brcm,sd-head-align", &align) == 0)
> + sdio->sd_head_align = align;

Hi Alexey

I think you can make this:

of_property_read_u16(np, "brcm,sd-head-align", &sdio->sd_head_align);

of_property_read_u16() should not touch the destination variable if
the properties does not exist, or if there is an error.

Andrew