Re: [PATCHv2 4/5] arm64: dts: allwinner: a64: Add pwm device

From: Andrà Przywara
Date: Sun Mar 18 2018 - 09:51:57 EST


On 18/03/18 12:52, Rob Herring wrote:
> On Thu, Mar 15, 2018 at 04:25:09PM +0000, Harald Geyer wrote:
>> This device is compatible with A13, so no new driver is needed.
>> A new compatible string is reserved in the binding documentation, to be
>> used together with the proper fall back. Tested on Teres-I.
>>
>> Signed-off-by: Harald Geyer <harald@xxxxxxxxx>
>> ---
>> changes since v1:
>> * add and use an A64 specific compatible string
>> * claim the full memory range
>>
>> I saw that Andre Przywara has been working on A64 pwm too and has
>> submitted some patches a few days ago. I think his patches are functionally
>> equivalent to this one here, but clean up things a bit and additionally
>> add support for r_pwm and thus are preferable. See:
>>
>> https://groups.google.com/forum/#!topic/linux-sunxi/hQFeteP591k
>>
>> I'm including my patch here mostly to have a consistent series for others
>> to test. OTOH you might merge the device tree changes here and pick up
>> the cleanup patches from him. Either way should work fine.
>
> I would sync up with Andre and send out a combined series. Don't make
> the maintainer(s) have to sort this out.

I have something ready, but need to test it. Will try to send an updated
series later tonight.

Thanks,
Andre.

>
>> Documentation/devicetree/bindings/pwm/pwm-sun4i.txt | 1 +
>> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 14 ++++++++++++++
>> 2 files changed, 15 insertions(+)
>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>