Re: [PATCH v4 1/2] kernel.h: Introduce const_max() for VLA removal

From: Linus Torvalds
Date: Thu Mar 15 2018 - 17:42:22 EST


On Thu, Mar 15, 2018 at 12:47 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> To gain the ability to compare differing types, the arguments are
> explicitly cast to size_t.

Ugh, I really hate this.

It silently does insane things if you do

const_max(-1,6)

and there is nothing in the name that implies that you can't use
negative constants.

Linus