Re: [PATCH] perf trace: __print_array should print hex format instead of dec

From: Steven Rostedt
Date: Thu Mar 15 2018 - 13:34:53 EST


On Thu, 15 Mar 2018 13:20:25 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Tue, 13 Mar 2018 11:27:32 -0300
> Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
>
> > Em Tue, Mar 13, 2018 at 06:39:17PM +0800, changbin.du@xxxxxxxxx escreveu:
> > > From: Changbin Du <changbin.du@xxxxxxxxx>
> > >
> > > The token '__print_array' is to print the array in hex format, but not
> > > decimal numbers. The implementation of __print_array in kernel side is:
> > > __print_array()->trace_print_array_seq()
> > >
> > > This patch align the perf's behavior with kernel so we have a consistent
> > > event format.
> >
> > Look ok, i.e. makes the userspace formatting do what the equivalent
> > kernel code does, Rostedt, Ack?
> >
>
> Thanks for sending this to me. I'll see how it affects trace-cmd, and
> let you know.
>

Looks good!

Acked-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

-- Steve