Re: [PATCH v3] vsprintf: Prevent crash when dereferencing invalid pointers

From: Petr Mladek
Date: Thu Mar 15 2018 - 11:26:14 EST


On Thu 2018-03-15 15:09:03, Andy Shevchenko wrote:
> On Wed, 2018-03-14 at 15:09 +0100, Petr Mladek wrote:
> > We already prevent crash when dereferencing some obviously broken
> > pointers. But the handling is not consistent. Sometimes we print
> > "(null)"
> > only for pure NULL pointer, sometimes for pointers in the first
> > page and
>
>
> > sometimes also for pointers in the last page (error codes).
>
> I still think that printing a hex value of the error code is much better
> than some odd "(efault)".

Do you mean (err:0e)? Google gives rather confusing answers for this.

I am not super excited about (efault). But it seems to be less
cryptic and the style is more similar to (null).

Best Regards,
Petr