Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

From: John Crispin
Date: Thu Mar 15 2018 - 07:07:36 EST




On 15/03/18 11:48, Dan Carpenter wrote:
This all seems fine. Generally the requirements for staging are that it
has a TODO, someone to work on it, and it doesn't break the build. But
some of the patches don't have commit message and those are required and
some of the commit messages are just the changes you have made not don't
describe the actual code...

John Crispin's email is john@xxxxxxxxxxxx

regards,
dan carpenter

Hi All,

looks like i was CC'ed on the openwrt addr, which no longer exists. This series makes no sense. None of the stuff posted is anywhere near ready to be upstreamed.

* we dont need a dedicated pinctrl driver, pinctrl-single will work fine on these SoCs
* the DMA/sdhci driver is a hacked up version of the SDK driver.
* drivers/net/ethernet/mediatek/* works on mt7623 and is easily portable to mt7621, same goes for the gsw driver.

ÂÂÂ John