Re: [PATCH 04/14] x86: use generic swiotlb_ops

From: Thomas Gleixner
Date: Thu Mar 15 2018 - 05:01:14 EST


On Wed, 14 Mar 2018, Christoph Hellwig wrote:
> #if defined(CONFIG_INTEL_IOMMU) || defined(CONFIG_AMD_IOMMU)
> void *iommu; /* hook for IOMMU specific extension */
> #endif
> +#ifdef CONFIG_STA2X11
> + bool is_sta2x11 : 1;

Huch? Please use either bool or an unsigned int based bitfield. A boolean
bitfield doesn't make sense.

Thanks,

tglx