Re: [PATCH] [v2] y2038: introduce struct __kernel_old_timeval

From: Thomas Gleixner
Date: Thu Mar 15 2018 - 04:44:35 EST


On Wed, 14 Mar 2018, Arnd Bergmann wrote:
>
> /*
> + * legacy timeval structure, only embedded in structures that
> + * traditionally used 'timeval' to pass time intervals (not absolute
> + * times). Do not add new users. If user space fails to compile
> + * here, this is probably because it is not y2038 safe and needs to
> + * be changed to use another interface.
> + */
> +struct __kernel_old_timeval {
> + __kernel_long_t tv_sec; /* seconds */
> + __kernel_long_t tv_usec; /* microseconds */

Please don't use these horrible tail comments. If you want to document the
obvious, then please use proper kernel doc.

Thanks,

tglx