Re: [PATCH] bfa: remove VLA
From: Martin K. Petersen
Date: Thu Mar 15 2018 - 00:38:04 EST
Stephen,
> bfad_bsg.c uses a variable-length array declaration to measure the
> size of a putative array; this can be replaced by the product of the
> size of an element and the number of elements, avoiding the VLA
> altogether.
>
> - sizeof(wwn_t[iocmd->nports])) != BFA_STATUS_OK) {
> + sizeof(wwn_t) * iocmd->nports) != BFA_STATUS_OK) {
These parentheses made me blurry eyed but it's actually OK.
Applied to 4.17/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering