Re: [PATCH v2] PCI/DPC: Fix PCI legacy interrupt acknowledgement

From: Keith Busch
Date: Wed Mar 14 2018 - 16:50:38 EST


On Wed, Mar 14, 2018 at 09:20:48PM +0530, Oza Pawandeep wrote:
> Current DPC driver acknowledges the interrupt in deferred work, which works
> since MSI are edge triggered.
>
> But when MSI is disabled (e.g. pci=nomsi boot option) port service
> driver falls back to PCI legacy INT interrupt.
>
> With current code we do not acknowledge the interrupt back in dpc_irq()
> and we get dpc interrupt storm.
>
> This patch acknowledges the interrupt in interrupt handler.
>
> Signed-off-by: Oza Pawandeep <poza@xxxxxxxxxxxxxx>

Thanks, this looks good to me.

Reviewed-by: Keith Busch <keith