RE: [PATCH v2]PCI: hv: fix PCI-BUS domainID corruption

From: Michael Kelley (EOSG)
Date: Wed Mar 14 2018 - 15:56:23 EST


> -----Original Message-----
> From: Sridhar Pitchai
> Sent: Wednesday, March 14, 2018 11:08 AM
> To: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>; Michael Kelley (EOSG)
> <Michael.H.Kelley@xxxxxxxxxxxxx>
> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>; Jake Oshins <jakeo@xxxxxxxxxxxxx>; Haiyang
> Zhang <haiyangz@xxxxxxxxxxxxx>; Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>; Dexuan
> Cui <decui@xxxxxxxxxxxxx>; KY Srinivasan <kys@xxxxxxxxxxxxx>;
> devel@xxxxxxxxxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH v2]PCI: hv: fix PCI-BUS domainID corruption
>
> Whenever PCI bus is added, HyperV guarantees the BUS id is unique. Even with
> that when a first device is added to the bus, it overrides bus domain ID with
> the device serial number. Sometime this can result in BUS ID not being unique.
> In this case, when PCI_BUS and a device added to the bus, even before the PCI
> BUS is added to kernel, the first device tends to overwrite the domain ID with
> 0. Since there exists a PCI bus with domain ID 0 already the PCI bus addition
> fails. This patch make sure when a device is added to a bus, it never updated
> the bus domain ID. Since we have the transparent SRIOV mode now, the short VF
> device name is no longer needed.
>
> Fixes: 4a9b0933bdfc("PCI:hv:Use device serial number as PCI domain")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Sridhar Pitchai <srpitcha@xxxxxxxxxxxxx>
> ---

Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>