Re: [PATCH] mailbox: tegra: relax TEGRA_HSP_MBOX Kconfig dependencies

From: Thierry Reding
Date: Tue Mar 13 2018 - 09:37:09 EST


On Tue, Mar 13, 2018 at 01:11:43PM +0100, Arnd Bergmann wrote:
> With the addition of the ARCH_TEGRA_194_SOC driver, we get a new Kconfig warning:
>
> warning: (ARCH_TEGRA_186_SOC && ARCH_TEGRA_194_SOC) selects TEGRA_HSP_MBOX which has unmet direct dependencies (MAILBOX && ARCH_TEGRA_186_SOC)
>
> It looks like the dependency is a bit too strict here, allowing the driver to
> be built for any Tegra chip avoids the problem.
>
> Fixes: 6f9ed07fde03 ("soc/tegra: Add Tegra194 SoC configuration option")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/mailbox/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

The HSP does not exist on any chip prior to Tegra186, which is what the
dependency reflects. However, I agree that there is little point for an
exact list of per-chip dependencies. We don't really support non-multi-
platform kernels anymore, or at least they don't get any testing, so
relaxing the dependency is fine with me.

Acked-by: Thierry Reding <treding@xxxxxxxxxx>

Thanks for fixing this,
Thierry

Attachment: signature.asc
Description: PGP signature