Re: hwmon/sch5627: Use common error handling code in sch5627_probe()

From: SF Markus Elfring
Date: Tue Mar 13 2018 - 04:27:00 EST


>> Adjust jump targets so that a bit of exception handling can be better
>> reused at the end of this function.
â
> goto-s going to a label calling another goto is completely unreadable.

I got an other software development view.


> I really do not see any reason for the proposed changes,

I suggest to look once more.


> they may remove a small amount of code duplication,

This was my software design goal in this case.


> but at a hugh cost wrt readability.

I proposed a different trade-off here.

Regards,
Markus