Re: çå: [PATCH] Delete some unusefull operations for centaur CPU/platform

From: Ingo Molnar
Date: Mon Mar 12 2018 - 05:46:28 EST



* Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:

> On Monday, March 12, 2018 9:40:33 AM CET Ingo Molnar wrote:
> >
> > * David Wang <DavidWang@xxxxxxxxxxx> wrote:
> >
> > > [David] pr->flags.has_cst means BIOS define valid C state table. And at lease
> > > define 2 entries. On all centaur platform which support C3, this condition is
> > > always true.
> >
> > > [David] Just as the following comment said, we need not execute WBINVD and
> > > ARB_DISABLE/ARB_ENABLE when entering C3 if bm_check=1 and bm_control=0. This
> > > logic is valid for all platform not only for Centaur, I think.
> >
> > Ok, fair enough!
>
> Well, I still have this one queued up as cpuidle material.
>
> I can drop it if you want to take it instead.

No need to drop it, it looks good to me!

Thanks,

Ingo