Re: [PATCH v2 01/13] PCI/portdrv: Merge pcieport_if.h into portdrv.h

From: Christoph Hellwig
Date: Mon Mar 12 2018 - 04:00:01 EST


On Fri, Mar 09, 2018 at 12:59:54PM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>
> pcieport_if.h contained the interfaces to register port service driver,
> e.g., pcie_port_service_register(). portdrv.h contained internal data
> structures of the port driver.
>
> I don't think it's worth keeping those files separate, since both headers
> and their users are all inside the PCI core.
>
> Merge pcieport_if.h directly in drivers/pci/pcie/portdrv.h and update the
> users to include that instead.

Looks good to me. I always found the old struture rather confusing..

Reviewed-by: Christoph Hellwig <hch@xxxxxx>