Re: [PATCH v1 3/5] dt-bindings: clock: add clocks for MT2712

From: Matthias Brugger
Date: Sun Mar 11 2018 - 18:30:03 EST




On 03/02/2018 03:23 AM, Weiyi Lu wrote:
> On Thu, 2018-03-01 at 16:45 -0600, Rob Herring wrote:
>> On Thu, Feb 22, 2018 at 01:48:49PM +0800, Weiyi Lu wrote:
>>> add new clocks according to ECO design change
>>>
>>> Signed-off-by: Weiyi Lu <weiyi.lu@xxxxxxxxxxxx>
>>> ---
>>> include/dt-bindings/clock/mt2712-clk.h | 294 +++++++++++++++++----------------
>>> 1 file changed, 151 insertions(+), 143 deletions(-)
>>
>> You can't just renumber your clocks. They are an ABI. Plus, for an ECO
>> there can't have been that much change.
>>
> Hi Rob,
> Got it! Is it correct if I append those new added clocks at the bottom
> of each own subsystem? If the answer is yes, I'll resend a new version.

Yes, that will work. Please do that and resubmit.

Thanks,
Matthias