Re: [PATCH v3 01/10] drivers: qcom: rpmh-rsc: add RPMH controller for QCOM SoCs

From: Stephen Boyd
Date: Fri Mar 09 2018 - 16:37:20 EST


On Fri, Mar 9, 2018 at 1:33 PM, Lina Iyer <ilina@xxxxxxxxxxxxxx> wrote:
> Hi Stephen,
>
> I will address all the comments in the next spin of the patch. Here are
> some responses to the questions.
>
> On Tue, Mar 06 2018 at 12:45 -0700, Stephen Boyd wrote:
>>
>> Quoting Lina Iyer (2018-03-02 08:43:08)
>
> [...]
>>
>> +#include <linux/module.h>
>>
>> If the driver doesn't become tristate, this should become export.h
>> instead of module.h
>>
> MODULE_DEVICE_TABLE seems to need this.
>

If you don't have tristate then MODULE_DEVICE_TABLE isn't needed.