Re: [PATCH] perf tools arm64: Add libdw DWARF post unwind support for ARM64

[Martin Vuille]

Hi,

I made two other submissions that may also have been overlooked:

https://patchwork.kernel.org/patch/10211401/ -- This one has the S-o-B

https://patchwork.kernel.org/patch/10211473/ -- RFC, was looking for comments, has the S-o-B


For https://patchwork.kernel.org/patch/10211483/, I'm not sure how to go about doing a reply to all.

I had some email problems and was cut-off from the list for a while.

MV


On 03/09/18 13:24, Arnaldo Carvalho de Melo wrote:
> Em Fri, Mar 09, 2018 at 12:07:20PM -0600, Kim Phillips escreveu:
> > On Fri, 9 Mar 2018 12:06:27 -0300
> > Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> >
> > Hi Arnaldo,
> >
> > > Em Thu, Mar 08, 2018 at 09:10:30PM -0600, Kim Phillips escreveu:
> > > > Based on prior work:
> > > >
> > > > https://lkml.org/lkml/2014/5/6/395
> > > Thanks, looks good, applying.
> > >
> > > Jean, is everything ok with you on this?
> > By now your email to Jean should have bounced with "The email account
> > that you tried to reach does not exist."  Removing Jean from Cc.
> >
> > It seems like you're applying patches.  There are a couple that have
> > slipped through the cracks: Can you please take a look at applying them?
> >
> > - "perf tools: Fixing uninitialised variable"
> >    https://patchwork.kernel.org/patch/10179381/
> [acme@jouet perf]$ git tag --contains d2785de15f1bd42d613d56bbac5a007e7293b874
> perf-core-for-mingo-4.17-20180216
>
> commit d2785de15f1bd42d613d56bbac5a007e7293b874
> Author:     Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
> AuthorDate: Mon Feb 12 13:32:37 2018 -0700
> Commit:     Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> CommitDate: Fri Feb 16 14:55:40 2018 -0300
>
>      perf auxtrace arm: Fixing uninitialised variable
>      
>      When working natively on arm64 the compiler gets pesky and complains
>      that variable 'i' is uninitialised, something that breaks the
>      compilation.  Here no further checks are needed since variable
>      'found_spe' can only be true if variable 'i' has been initialised as
>      part of the for loop.
>      
>      Signed-off-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
>      Cc: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
>      Cc: Jin Yao <yao.jin@xxxxxxxxxxxxxxx>
>      Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
>      Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>      Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>      Link: http://lkml.kernel.org/r/1518467557-18505-4-git-send-email-mathieu.poirier@xxxxxxxxxx
>      Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>
> diff --git a/tools/perf/arch/arm/util/auxtrace.c b/tools/perf/arch/arm/util/auxtrace.c
> index 2323581b157d..fa639e3e52ac 100644
> --- a/tools/perf/arch/arm/util/auxtrace.c
> +++ b/tools/perf/arch/arm/util/auxtrace.c
> @@ -68,7 +68,7 @@ struct auxtrace_record
>          bool found_spe = false;
>          static struct perf_pmu **arm_spe_pmus = NULL;
>          static int nr_spes = 0;
> -       int i;
> +       int i = 0;
>   
> > - "perf unwind: Report error from dwfl_attach_state"
> >    https://patchwork.kernel.org/patch/10211483/
> >    [Martin, I guess it would help if you replied-all that patch and
> >     added your signed-off-by.]
> Right, the S-o-B is needed
>   
> > - "perf unwind: Unwind with libdw doesn't take symfs into account"
> >    https://patchwork.kernel.org/patch/10211599/
> This one has the S-o-B, applying, Jiri, holler if you disagree,
>
> - Arnaldo
>   
> > Thanks,
> >
> > Kim
> --
> To unsubscribe from this list: send the line "unsubscribe linux-perf-users" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html