Re: [PATCH] pktgen: Remove VLA usage

From: David Miller
Date: Fri Mar 09 2018 - 11:58:19 EST


From: "Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx>
Date: Thu, 8 Mar 2018 23:43:40 -0600

> In preparation to enabling -Wvla, remove VLA usage and replace it
> with a fixed-length array instead.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> ---
> David,
>
> I'm not sure how often this function is being called and,
> depending on the frequency it may be worth to use
> dynamic memory allocation instead?

It happens every time a config setting is made via the sysfs
files when debug is enabled.

This is not something that happens often.

So your patch is fine, applied to net-next, thanks.