Re: [PATCH v3 2/4] rtc: at91sam9: Pass pdev->dev to regmap_init_mmio()

[JeffyChen]

Hi Alexandre,

On 03/09/2018 04:49 AM, Alexandre Belloni wrote:
> On 08/03/2018 at 18:21:52 +0800, Jeffy Chen wrote:
> > Otherwise it would use "dummy*" to create regmap debugfs dir.
> >
> > Signed-off-by: Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx>
> > ---
> >
> > Changes in v3: None
> >
> >   drivers/rtc/rtc-at91sam9.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c
> > index 7418a763ce52..0d6a17a77841 100644
> > --- a/drivers/rtc/rtc-at91sam9.c
> > +++ b/drivers/rtc/rtc-at91sam9.c
> > @@ -402,7 +402,7 @@ static int at91_rtc_probe(struct platform_device *pdev)
> >   		if (IS_ERR(gpbr))
> >   			return PTR_ERR(gpbr);
> >
> > -		rtc->gpbr = regmap_init_mmio(NULL, gpbr,
> > +		rtc->gpbr = regmap_init_mmio(&pdev->dev, gpbr,
> >   					     &gpbr_regmap_config);
>
> This would be misleading as the gpbr is not directly related to the rtc.
ok, will fix that, thanks.
>