Re: [Xen-devel] [PATCH v2] xen/acpi: upload _PSD info for non Dom0 CPUs too

From: Boris Ostrovsky
Date: Thu Mar 08 2018 - 17:34:32 EST




On 03/08/2018 05:57 AM, Joao Martins wrote:

@@ -372,6 +376,15 @@ read_acpi_id(acpi_handle handle, u32 lvl, void *context, void **rv)
pr_debug("ACPI CPU%u w/ PBLK:0x%lx\n", acpi_id, (unsigned long)pblk);
+ /* It has P-state dependencies */
+ if (!acpi_processor_get_psd(handle, &acpi_psd[acpi_id])) {
+ __set_bit(acpi_id, acpi_id_psd_present);
+
+ pr_debug("ACPI CPU%u w/ PST:coord_type = %llu domain = %llu\n",
+ acpi_id, acpi_psd[acpi_id].coord_type,
+ acpi_psd[acpi_id].domain);
+ }


I should have noticed this earlier, but do you really need acpi_id_psd_present? Can you just go by acpi_psd[i] != NULL?

Sorry for missing it in the first patch.

-boris