Re: [PATCH] usb: musb: Fix external abort in musb_remove

From: Merlijn Wajer
Date: Thu Mar 08 2018 - 17:18:09 EST


Hi,

On 08/03/18 22:15, Bin Liu wrote:

> please add patch version numbers in the subject when necessary. This
> helps cross-referencing.

Will do. I naively assumed that the first patch would implicitly be
number 1. Will send out v2 now.

>>
>> + musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
>
> Does it solve the issue if not moving this line? I'd like to have
> minimum change if possible.

Yes, it does. The only reason I moved musb_writeb is because I
understood you wanted me to move both (per previous message: "This can
be move down to out side of holding the spinlock").

Thanks for the tips.

Cheers,
Merlijn

Attachment: signature.asc
Description: OpenPGP digital signature