Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

From: Laxman Dewangan
Date: Thu Mar 08 2018 - 10:21:30 EST




On Thursday 08 March 2018 08:01 PM, Guenter Roeck wrote:
On 03/07/2018 10:06 PM, Laxman Dewangan wrote:


The RPM is measured speed via PWM signal capture which is output from fan.
So should we have the fan[1..n]_output_rpm?


No. I hear you clearly that you for some reason dislike fan[1..n]_input.
While ABIs are not always to our liking, that doesn't mean that we get
to change them at our whim. If that is not acceptable for you, I can't
help you. And you can't change inX_input to inX_voltage either, sorry.

My opinion is only to not use "input" as this is not really the input to fan.