Re: [PATCH v2 1/2] dt-bindings: watchdog: Add Nuvoton NPCM description

From: Tomer Maimon
Date: Thu Mar 08 2018 - 02:47:07 EST


On 5 March 2018 at 13:45, Joel Stanley <joel@xxxxxxxxx> wrote:
> These bindings describe the watchdog IP as used by the Nuvoton NPCM750
> (Poleg) BMC SoC.
>
> Signed-off-by: Joel Stanley <joel@xxxxxxxxx>
> ---
> V2: Add optional timeout property
> ---
> .../bindings/watchdog/nuvoton,npcm-wdt.txt | 28 ++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt b/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt
> new file mode 100644
> index 000000000000..615eacd0b9d6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt
> @@ -0,0 +1,28 @@
> +Nuvoton NPCM Watchdog
> +
> +Nuvoton NPCM timer module provides five 24-bit timer counters, and a watchdog.
> +The watchdog supports a pre-timeout interrupt that fires 10ms before the
> +expiry.
> +
> +Required properties:
> +- compatible : "nuvoton,npcm750-wdt" for NPCM750 (Poleg).
> +- reg : Offset and length of the register set for the device.
> +- interrupts : Contain the timer interrupt with flags for
> + falling edge.
> +
> +Required clocking property, have to be one of:
> +- clocks : phandle of timer reference clock.
> +- clock-frequency : The frequency in Hz of the clock that drives the NPCM7xx
> + timer (usually 25000000).
> +
> +Optional properties:
> +- timeout-sec : Contains the watchdog timeout in seconds
> +
> +Example:
> +
> +timer@f00080c1 {
Little address mistake, suppose to be f000801c
> + compatible = "nuvoton,npcm750-wdt";
> + interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0xf00080c1 0x4>;
Little address mistake, suppose to be 0xf000801c
> + clocks = <&clk NPCM7XX_CLK_TIMER>;
> +};
> --
> 2.15.1
>