Re: [PATCH net 1/2] net/macmace: Drop redundant MACH_IS_MAC test

From: Geert Uytterhoeven
Date: Wed Feb 28 2018 - 04:24:31 EST


On Wed, Feb 28, 2018 at 5:22 AM, Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
> The MACH_IS_MAC test is redundant here because the platform device
> won't get registered unless MACH_IS_MAC.
> Adopt module_platform_driver() convention.
>
> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds