Re: [PATCH v1 4/4] pci: Re-use new dmi_get_bios_year() helper

From: Andy Shevchenko
Date: Sun Feb 25 2018 - 08:27:15 EST


On Fri, 2018-02-23 at 15:40 -0600, Bjorn Helgaas wrote:
> Please use
>
> PCI: Re-use ...
>
> to match the prevailing drivers/pci style.

Noted. (Same for x86/PCI part)

> On Thu, Feb 22, 2018 at 02:59:23PM +0200, Andy Shevchenko wrote:
> > ...instead of open coding its functionality.
>
> Same comment about making the changelog complete, independent of the
> subject.

Any suggestion how it would look like? (Same question for previous
comment)

> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>

Thanks!

> Let me know if you want me to take the series. Otherwise I'll assume
> it
> goes elsewhere.

Ingo took them into x86/platform.

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy