Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context

From: Sebastian Andrzej Siewior
Date: Tue Feb 06 2018 - 11:59:10 EST


On 2018-01-17 17:24:47 [-0500], David Miller wrote:
> From: Eric Dumazet <edumazet@xxxxxxxxxx>
> Date: Wed, 17 Jan 2018 14:02:43 -0800
> > There is also the netif_rx_ni() stuff.
> >
> > Can't remember right now why it is not using
> > local_bh_{diable,enable}() pair instead
> > of preempt_disable() ... if (local_softirq_pending()) do_softirq();
>
> Hmmm, that code predates the initial GIT repository build.
>
> I do remember we had some back and forth with that stuff.

So I did a little research and tried to replace preempt_disable() with
local_bh_disable() [0] a while ago.

[0] https://lkml.kernel.org/r/20170616172400.10809-1-bigeasy@xxxxxxxxxxxxx

Sebastian