Re: [PATCH -next] meson-gx-socinfo: make local function meson_gx_socinfo_init static

From: Neil Armstrong
Date: Tue Feb 06 2018 - 07:25:33 EST


On 10/01/2018 15:19, Wei Yongjun wrote:
> Fixes the following sparse warnings:
>
> drivers/soc/amlogic/meson-gx-socinfo.c:100:12: warning:
> symbol 'meson_gx_socinfo_init' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
> drivers/soc/amlogic/meson-gx-socinfo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
> index f2d8c3c..ea091f1 100644
> --- a/drivers/soc/amlogic/meson-gx-socinfo.c
> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c
> @@ -97,7 +97,7 @@ static const char *socinfo_to_soc_id(u32 socinfo)
> return "Unknown";
> }
>
> -int __init meson_gx_socinfo_init(void)
> +static int __init meson_gx_socinfo_init(void)
> {
> struct soc_device_attribute *soc_dev_attr;
> struct soc_device *soc_dev;
>
>
>

Acked-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>