Re: [PATCH v3 2/2] ASoC: ak5558: Add bindings for AK5558 ADC

From: Fabio Estevam
Date: Mon Feb 05 2018 - 15:26:51 EST


On Mon, Feb 5, 2018 at 3:01 PM, Daniel Baluta <daniel.baluta@xxxxxxx> wrote:
> Document the bindings for AK5558 ADC.
>
> Signed-off-by: Daniel Baluta <daniel.baluta@xxxxxxx>
> ---
> Documentation/devicetree/bindings/sound/ak5558.txt | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/ak5558.txt b/Documentation/devicetree/bindings/sound/ak5558.txt
> new file mode 100644
> index 0000000..7d67ca6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/ak5558.txt
> @@ -0,0 +1,22 @@
> +AK5558 8 channel differential 32-bit delta-sigma ADC
> +
> +This device supports I2C mode only.
> +
> +Required properties:
> +
> +- compatible : "asahi-kasei,ak5558"
> +- reg : The I2C address of the device.
> +
> +Optional properties:
> +
> +- reset-gpios: A GPIO specifier for the power down & reset pin.
> +
> +Example:
> +
> +&i2c {
> + ak5558: adc@10 {

If I understood well Rob's suggestion was to make it only:

adc@10 {

Other than that:

Reviewed-by: Fabio Estevam <fabio.estevam@xxxxxxx>