Re: [RFC][PATCH] <linux/stringhash.h>: fix end_name_hash() for 64bit long

From: Amir Goldstein
Date: Mon Feb 05 2018 - 13:35:37 EST


On Mon, Feb 5, 2018 at 7:57 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Feb 5, 2018 at 9:51 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
>>
>> and hash_32_generic() is just __hash_32() with zero shift.
>
> Right. But that __hash_32() is very expensive and doesn't help.
>
> So the patch as-is doesn't seem to buy anything, and only adds cost.

But my patch doesn't add any __hash_32() call. It was already there.
Anyway, I'll drop the patch.

Thanks,
Amir.