Re: [PATCH 08/19] clk: meson: add regmap to the clock controllers

From: Jerome Brunet
Date: Mon Feb 05 2018 - 04:51:34 EST


On Sat, 2018-02-03 at 19:53 +0100, Martin Blumenstingl wrote:
> On Wed, Jan 31, 2018 at 7:09 PM, Jerome Brunet <jbrunet@xxxxxxxxxxxx> wrote:
> > This change register a regmap in meson8b, gxbb and axg controllers.
> > The clock are still accessing their registers directly through iomem.
> > Once all clocks handled by these controllers have been move to regmap,
> > the regmap register will be removed and replaced with a syscon request.
>
> maybe you can add a comment that some of the registers from this area
> need to be accessed outside the clock driver (by the HDMI driver for
> example - which is the case on GX and Meson8/8b IIRC) if you have to
> re-spin this series

I think it was mentioned in the cover letter, but you are right, I should
mention it here as well.

>
> > Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
>
> Acked-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>