Re: [PATCH v12 1/3] lib: Add strongly typed 64bit int_sqrt

From: Jonathan Cameron
Date: Sun Feb 04 2018 - 05:19:37 EST


On Mon, 15 Jan 2018 02:36:15 -0800
Joe Perches <joe@xxxxxxxxxxx> wrote:

> On Wed, 2018-01-10 at 09:37 +0100, Crt Mori wrote:
> > Shouldn't I rather make it
> >
> > if (x <= ULONG_MAX)
> > return int_sqrt((unsigned long) x);
>
> With this change: (I believe done in v13) and
> as requested by Crt Mori in a private email:
>
> Acked-by: Joe Perches <joe@xxxxxxxxxxx>

Thanks Joe,

I've applied v13 which indeed does have this change.
Applied to the togreg branch of iio.git where it will sit until after
the merge window.

For now I'll only be pushing that out as a build test branch so
still time for improvements without having to revert or anything.

Thanks,

Jonathan

>