Re: [PATCH 3/3] PCI: designware-ep: Return an error when requesting a too large BAR size

From: Jingoo Han
Date: Thu Feb 01 2018 - 14:00:57 EST


On Thursday, February 1, 2018 1:58 PM, Andy Shevchenko wrote:
>
> On Thu, Feb 1, 2018 at 6:11 PM, Niklas Cassel <niklas.cassel@xxxxxxxx>
> wrote:
>
> include/linux/sizes.h:
>
> +SZ_4G 0x100000000ULL
>
> > + if (size > 0x100000000ULL) {
>
> #include <linux/sizes.h>
>
> if (size > SZ_4G) {

I like this one for the readability.
Thank you.

Best regards,
Jingoo Han

>
> ?
>
> --
> With Best Regards,
> Andy Shevchenko