Re: [PATCH 02/24] objtool: Add retpoline validation

From: Borislav Petkov
Date: Tue Jan 23 2018 - 13:21:42 EST


On Tue, Jan 23, 2018 at 04:25:41PM +0100, Peter Zijlstra wrote:
> David requested a objtool validation pass for RETPOLINE enabled
> builds, where it validates no unannotated indirect jumps or calls are
> left.
>
> Add an additional .discard.retpoline_safe section to allow annotating
> the few indirect sites that are required and safe.
>
> Requested-by: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> ---
> scripts/Makefile.build | 4 +
> tools/objtool/builtin-check.c | 3 -
> tools/objtool/builtin.h | 2
> tools/objtool/check.c | 87 ++++++++++++++++++++++++++++++++++++++++--
> tools/objtool/check.h | 1
> 5 files changed, 92 insertions(+), 5 deletions(-)

Yap, very noisy:

$ grep indirect build.log | wc -l
12904

Let's see how many will remain at the end of the patchset. :)

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.