Re: [PATCH 2/2] net/ibm/emac: wrong bit is used for STA control register write

[Ivan Mikhaylov]

> So if someone tries to #define EMAC_STACR_STAC_WRITE BIT(18) it would be
> 0x40000 instead. This is where the confusion is coming from. Can you please
> at least mention this somewhere that all the bits in the commit message are
> in "MSB 0" format? It's confusing enough as it is ;).
Yeap, sure, will do.

> Well, the MASK is not used and it now looks odd. So you might as well
> delete it. Maybe as well as all the unused EMACX_STACR_STAC_IND_* macros?
I'll check and delete if it's not used anywhere. Thanks for finding :)