Re: [PATCH] Intel-IOMMU: Delete an error message for a failed memory allocation in init_dmars()

From: Jörg Rödel
Date: Sun Jan 21 2018 - 02:19:16 EST


On Sat, Jan 20, 2018 at 05:37:52PM -0800, Joe Perches wrote:
> While Markus' commit messages are nearly universally terrible,
> is there really any signficant value in knowing when any
> particular OOM condition occurs other than the subsystem that
> became OOM?
>
> You're going to be hosed in any case.
>
> Why isn't the generic OOM stack dump good enough?

Because if we know the exact allocation attempt that failed right away,
we can more easily check if we can rewrite it so that it is more likely
to succeed, e.g. rewriting one higher-order allocation to multiple
order-0 allocations.


Joerg