Re: linux-next: build warning after merge of the crypto tree

From: Harsh Jain
Date: Thu Jan 18 2018 - 23:22:22 EST


Hi Herbert,

It's an indentation issue. Seems checkpatch and default compile options does not report this warning.

How would you like to take the fix. Should I sent whole series again with fix or only indentation patch.


On 19-01-2018 07:19, Stephen Rothwell wrote:
> Hi Herbert,
>
> After merging the crypto tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/crypto/chelsio/chcr_algo.c: In function 'create_authenc_wr':
> drivers/crypto/chelsio/chcr_algo.c:2113:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
> if (error)
> ^~
> drivers/crypto/chelsio/chcr_algo.c:2115:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
> dnents = sg_nents_xlen(req->dst, assoclen, CHCR_DST_SG_SIZE, 0);
> ^~~~~~
>
> Introduced by commit
>
> e1a018e607a3 ("crypto: chelsio - Remove dst sg size zero check")
>