Re: [PATCH v1 tip/master 1/3] retpoline: Introduce start/end markers of indirect thunk

From: Masami Hiramatsu
Date: Thu Jan 18 2018 - 10:34:53 EST


On Thu, 18 Jan 2018 12:06:10 +0000
"Woodhouse, David" <dwmw@xxxxxxxxxxxx> wrote:

> On Thu, 2018-01-18 at 21:01 +0900, Masami Hiramatsu wrote:
> >
> > +#define X86_INDIRECT_THUNK(reg)ÂÂÂÂÂÂÂÂ\
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ*(.text.__x86.indirect_thunk.##reg)
>
> Note that we don't actually care about those being in their own
> section, named after the register. That was just a hangover from the
> initial GCC COMDAT implementation.
>
> If it makes your life easier just to put them all in a single section,
> go ahead.

Got it. I just concerned that gcc was using this section.
I'll make it ".text.__x86.indirect_thunk" to consolidate.

Thanks!

--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>