Re: [PATCH] can: m_can: mark runtime-PM handlers as __maybe_unused

From: Marc Kleine-Budde
Date: Thu Jan 18 2018 - 08:17:11 EST


On 01/18/2018 02:04 PM, Arnd Bergmann wrote:
> Building without CONFIG_PM results in a harmless warning:
>
> drivers/net/can/m_can/m_can.c:1763:12: error: 'm_can_runtime_resume' defined but not used [-Werror=unused-function]
> drivers/net/can/m_can/m_can.c:1752:12: error: 'm_can_runtime_suspend' defined but not used [-Werror=unused-function]
>
> Marking the functions as __maybe_unused lets the compiler
> silently drop them instead.
>
> Fixes: cdf8259d6573 ("can: m_can: Add PM Support")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Tnx - applied.

However all archs using this driver have mandatory PM support and the
driver depends on it.

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |

Attachment: signature.asc
Description: OpenPGP digital signature