Re: [PATCH v3 01/12] iommu/rockchip: Prohibiat unbind and remove

[JeffyChen]

Hi Tomasz,

Thanks for your reply.

and just found i forgot to add iommu clocks for other rockchip 
platforms(rk3399 already has that)...will also do that in the next version.

On 01/18/2018 12:17 PM, Tomasz Figa wrote:
> On Thu, Jan 18, 2018 at 12:25 AM, Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx> wrote:
> > Removal the IOMMUs cannot be done reliably.
>
> nit: Perhaps "Removal of IOMMUs"?
ok
> > This is similar to exynos iommu driver.
> >
> > Signed-off-by: Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx>
> > ---
> >
> > Changes in v3:
> > Also remove remove() and module_exit() as Tomasz suggested.
> >
> > Changes in v2: None
> >
> >   drivers/iommu/rockchip-iommu.c | 21 +--------------------
> >   1 file changed, 1 insertion(+), 20 deletions(-)
>
> nit: Typo in subject: s/Prohibiat/Prohibit/
ok, will do that.
> Otherwise,
>
> Reviewed-by: Tomasz Figa <tfiga@xxxxxxxxxxxx>
>
> Best regards,
> Tomasz