Re: [PATCH] PCI / PM: Fix trailing semicolon

From: Rafael J. Wysocki
Date: Wed Jan 17 2018 - 20:32:24 EST


On Wednesday, January 17, 2018 7:21:49 PM CET Bjorn Helgaas wrote:
> [+cc Rafael]
>
> On Wed, Jan 17, 2018 at 10:33:21AM +0000, Luis de Bethencourt wrote:
> > The trailing semicolon is an empty statement that does no operation.
> > Removing it since it doesn't do anything.
> >
> > Signed-off-by: Luis de Bethencourt <luisbg@xxxxxxxxxx>
>
> Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>
> Rafael, I have nothing queued for pci-driver.c, and you've merged most
> of the recent changes there. If you have any pending changes to it,
> feel free to merge this one. Otherwise, I'll be happy to pick it up.
>
> I would change the subject to:
>
> PCI / PM: Remove spurious semicolon

OK, I'll take this one.

Thanks,
Rafael


> > ---
> >
> > Hi,
> >
> > After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> > suggested I fix it treewide [0].
> >
> > Best regards
> > Luis
> >
> >
> > [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> > [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
> >
> > drivers/pci/pci-driver.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
> > index d79dbc377b9c..5958c8dda4e3 100644
> > --- a/drivers/pci/pci-driver.c
> > +++ b/drivers/pci/pci-driver.c
> > @@ -968,7 +968,7 @@ static int pci_pm_freeze_late(struct device *dev)
> > if (dev_pm_smart_suspend_and_suspended(dev))
> > return 0;
> >
> > - return pm_generic_freeze_late(dev);;
> > + return pm_generic_freeze_late(dev);
> > }
> >
> > static int pci_pm_freeze_noirq(struct device *dev)
>